Skip to content

Cleanup analytics command, support markdown#348

Merged
pvdz merged 6 commits intomainfrom
analytics_v2
Mar 3, 2025
Merged

Cleanup analytics command, support markdown#348
pvdz merged 6 commits intomainfrom
analytics_v2

Conversation

@pvdz
Copy link
Contributor

@pvdz pvdz commented Mar 3, 2025

This is about the socket analytics command:

  • Supports the --markdown flag, which was previously advertised but completely ignored
    • Including the --file flag for it, just like --json
  • JSON to file will be formatted
  • JSON to stdout will be same as the one written to file
    • No more relying on console.log to do the formatting, or to hit depth limits
  • JSON serialization separately trapped
    • A bit redundant but it's possible for .stringify to hit cicular refs and fail hard
  • Fixed up the typing such that the SDK types are properly reflected
  • Added some input error conditions which are hidden by default

@pvdz pvdz requested a review from jdalton March 3, 2025 12:41
@pvdz pvdz merged commit 7e8c86e into main Mar 3, 2025
15 checks passed
@pvdz pvdz deleted the analytics_v2 branch March 3, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants